-
-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(build): refresh #1521
ci(build): refresh #1521
Conversation
validcube
commented
Nov 24, 2023
•
edited
Loading
edited
- test
- test
- test
- ci(pr-build): deemed unreliable #1540
⚒️ ReVanced PR Build workflow✅ ReVanced Manager 81a8671 build succeeded. Checkout the Dart static analyze check at job summary. Directly download the application artifact here. ⚙️ Overview
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the question I added in the review.
⚒️ ReVanced PR Build workflow✅ ReVanced Manager bdc282f build succeeded. Checkout the Dart static analyze check or download the artifact at job summary. ⚙️ Overview
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes, not required though.
path: | | ||
build/app/outputs/flutter-apk/app-${{ inputs.app-flavor }}.apk | ||
build/app/outputs/flutter-apk/app-${{ inputs.app-flavor }}.apk.sha1 | ||
|
||
- name: "Comment to Pull Request #${{ inputs.pr-number }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make this step comment as @revanced-bot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make this step comment as @revanced-bot?
This was mentioned in the initial pull request for ci(build), this suggestion depends on the repository manager which is out of my limit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repository manager being who? @oSumAtrIX can you look into this?
4b37202
to
f8ee197
Compare
Dropped, obsolete (soon:tm:) |