-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Accessibility): improve patch options #1369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs string changes.
Another problem with this page is the dialog. Currently, the "list item(s)" don't look like list items at all. It doesn't really tell the user it's clickable and is a choice.
What we could do is revert to the default list item styles and add a dummy radio button which will do absolutely nothing other than convince the user the list item is clickable like in the image below.
The behavior won't change, clicking on the list item won't make it selected, it will add the clicked option automatically.
Co-authored-by: Palm <[email protected]>
@oSumAtrIX What do you think about the solution I've proposed in the review? |
👋 Hello! Unfortunately, this is out-of-scope for this PR as this is targeted to improve usage accessibility tools like Android TalkBack, screen reader. (and small thing like contrasts) Feel like to open an issue about this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tooltip
Improve accessibility, and avoid user from accidentally resetting their patch options
Colour
Changed from Secondary Container to Surface to provide slightly better hierarchy.
Ignore commit message, something messed up
Yes, my budget for writing PR has temporarily dropped