Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Wrong renaming of exported apk if there is already an apk with the same name. #559

Closed
3 tasks done
d3EyedRaven opened this issue Dec 3, 2022 · 1 comment · Fixed by #837
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@d3EyedRaven
Copy link

Type

Other

Bug description

saving apk in same folder and with same name, saves apk with changed extension instead of , rendering apk useless.
on personal level, issue can be fixed by simple renaming.

example:
should save second export as
youtube-revanced_v17.45.36 1.apk
currently saves second export as : youtube-revanced_v17.45.36.apk 1

Steps to reproduce

1: export the apk after patching. save it in file manager (in my case mixplorer) with default naming "youtube-revanced_v17.45.36.apk"

2: patch youtube again with different patches, export again in the same folder as previously exported apk. and same name. it does not ask to change name or whether to replace old file.

3: instead it renames to "youtube-revanced_v17.45.36.apk 1" which renders apk useless due to the wrong extention. however a simple rename solve sthe issue.
it should be asking if to replace the old file or rename the filename, not with the extention.

Relevant log output

none

Screenshots or videos

No response

Solution

No response

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@d3EyedRaven d3EyedRaven added the Bug report Something isn't working label Dec 3, 2022
@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 3, 2022
@ILoveOpenSourceApplications

This still exists and needs to be looked into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants