Skip to content

Commit

Permalink
Merge branch 'dev' into feat/patch-options
Browse files Browse the repository at this point in the history
  • Loading branch information
validcube authored Oct 10, 2023
2 parents 74ff251 + 2abadc7 commit 9209872
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
6 changes: 3 additions & 3 deletions docs/2_1_patching.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ The following pages will guide you through using ReVanced Manager to patch apps.
4. Tap on the **Select patches** card and select the patches you want to apply[^2]
> **Warning**: If you see a warning you can click on it for more information.
5. Tap on the **Done** then **Patch** button
> **Warning**: The patching process may take ~5 minutes. Exiting the app may increase the time it takes to patch.
> **Warning**: The patching process may take ~5 minutes. Exiting the app may cancel patching or increase the time it takes to patch.
6. Tap on the **Install** button
> **Note**: If you are rooted, you can mount the patched app on top of the original app.[^3]
> Optionally, you may export the patched app to storage using the options in the top right corner.
> Optionally, you may export the patched app to storage using the option in the bottom left corner.
[^1]: Non-root users may be prompted to select an APK from storage, in which case you have to source the APK file yourself. ReVanced does not provide any APK files.
[^1]: Non-root users may be prompted to select an APK from storage, in which case you must source the APK file yourself. ReVanced does not provide any APK files.
[^2]: It is suggested to use the default set of patches by tapping on the **Default** button above the list of patches.
[^3]: Mounting the patched app on top of the original app will only work if the installed app version matches the version of the app selected in step 3. above.

Expand Down
6 changes: 1 addition & 5 deletions docs/3_troubleshooting.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ In case you encounter any issues while using ReVanced Manager, please refer to t

Make sure ReVanced Manager is up to date by following [πŸ”„ Updating ReVanced Manager](2_3_updating.md) and select the **Default** button when choosing patches.

- πŸ’₯ App not installed as package conflicts with an existing package
- 🚫 App not installed as package conflicts with an existing package

An existing installation of the app you're trying to patch is conflicting with the patched app. Uninstall the existing app before installing the patched app.

Expand All @@ -16,10 +16,6 @@ In case you encounter any issues while using ReVanced Manager, please refer to t

Alternatively, you can use [ReVanced CLI](https://github.com/revanced/revanced-cli) to patch the app.

- 🚫 Non-root install is not possible with the current patches selection

Select the **Default** button when choosing patches.

- 🚨 Patched app crashes on launch

Select the **Default** button when choosing patches.
Expand Down
4 changes: 3 additions & 1 deletion lib/ui/widgets/patcherView/patch_selector_card.dart
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ class PatchSelectorCard extends StatelessWidget {

String _getPatchesSelection() {
String text = '';
for (final Patch p in locator<PatcherViewModel>().selectedPatches) {
final List<Patch> selectedPatches = locator<PatcherViewModel>().selectedPatches;
selectedPatches.sort((a, b) => a.name.compareTo(b.name));
for (final Patch p in selectedPatches) {
text += 'β€’ ${p.getSimpleName()}\n';
}
return text.substring(0, text.length - 1);
Expand Down

0 comments on commit 9209872

Please sign in to comment.