Generate Missing Texture Texture #116
Conversation
source/client/renderer/Textures.cpp
Outdated
| t.m_pixels[2] = 0xff000000; | ||
| } | ||
|
|
||
| int result = assignTexture(name, t); |
There was a problem hiding this comment.
It looks like -1 was originally returned here to indicate an error occurred loading the texture. Surely there's a way to still allow for error detection & "texture not found" warnings while still keeping the placeholder textures.
There was a problem hiding this comment.
Since a texture is now always assigned, IMO, there's no reason for Textures to propagate the error.
Also, warnings still work. They're printed by AppPlatform.
There was a problem hiding this comment.
As long as warnings still work, then I don't really see any downsides here. Looks all good!
There was a problem hiding this comment.
BTW, you should probably replace the duplicate t.m_pixels check with an if-else branching statement.
There was a problem hiding this comment.
What duplicate check?
There was a problem hiding this comment.
Oh! Sorry, I was looking in my mail and saw something that looked like this. Totally didn't see the - and + signs, sorry
This generates a proper "missing texture" texture when one fails to load.
IMO this is way better than everything just defaulting to black. (Seriously, if you don't have assets loaded, the entire title-screen will be 100% black and it isn't that clear what the error is.)
This will also stop ReMCPE from spamming the console with error messages when it can't find a texture. (This issue was caused by it trying to load the texture every frame, but now it will only try to load it once.)
Screenshot:
