Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: give default weapons when not full equip set #23

Closed
wants to merge 0 commits into from

Conversation

golukon
Copy link
Contributor

@golukon golukon commented Jul 29, 2023

Fixing a bug with incomplete weapon selection and the absence of the selected weapon when spawning

@SergeyShorokhov
Copy link
Collaborator

SergeyShorokhov commented Aug 1, 2023

@golukon how to reproduce bug?

At the moment, unfortunately, I don't have a Windows device to test the changes. However, by the 8th I plan to do it when I get home

@golukon
Copy link
Contributor Author

golukon commented Aug 1, 2023

Fixing a bug with incomplete weapon selection and the absence of the selected weapon when spawning

You should choose primary weapon and then enter exit. Next round you can choose only secondary weapon, but you won't be having weapon, that you chose last round

@SergeyShorokhov
Copy link
Collaborator

@golukon Still buggy, no gun is given out, even if you select it.

@golukon
Copy link
Contributor Author

golukon commented Aug 10, 2023

@golukon Still buggy, no gun is given out, even if you select it.

It works for me

@SergeyShorokhov
Copy link
Collaborator

SergeyShorokhov commented Aug 14, 2023

@golukon I can't catch this bug on version:

Name: ReDeathmatch
Version: 1.0.0-beta.3
Author: Sergey Shorokhov
Filename: ReDeathmatch.amxx
Status: debug

I'm not closing the PR, maybe I'll come back to it if I figure out how to reproduce and at what config

@SergeyShorokhov SergeyShorokhov marked this pull request as draft August 14, 2023 13:45
@golukon
Copy link
Contributor Author

golukon commented Aug 25, 2023

@golukon Я не могу обнаружить эту ошибку в версии:

Name: ReDeathmatch
Version: 1.0.0-beta.3
Author: Sergey Shorokhov
Filename: ReDeathmatch.amxx
Status: debug

Я не закрываю PR, возможно, я вернусь к нему, если выясню, как воспроизвести и в какой конфигурации

I could record a demo if you need

@SergeyShorokhov SergeyShorokhov changed the title Update ReDM_equip_manager.inc fix: give default weapons when not full equip set Sep 12, 2023
@SergeyShorokhov
Copy link
Collaborator

SergeyShorokhov commented Sep 12, 2023

@golukon don't use master branch, I can't change master branch on your repo.

git push golukon golukon/fix-equipset:master
To https://github.com/golukon/ReDeathmatch.git
! [remote rejected] golukon/fix-equipset -> master (permission denied)
error: failed to push some refs to 'https://github.com/golukon/ReDeathmatch.git'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants