Feature tp adding confirmation dialogue #945
Conversation
…ssional or education) && Display contextual modal with relevant messages based on entryCategory && Implemented open and close modal functions && Integrated LightModal component for deletion confirmation
WalkthroughThe recent updates enhance the job seeker profile components by adding an Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant EditableEducation
participant EditableProfessionalExperience
participant FormDraggableAccordion
User->>EditableEducation: Fill education form
EditableEducation-->>User: Submit with entryCategory="education"
User->>EditableProfessionalExperience: Fill professional experience form
EditableProfessionalExperience-->>User: Submit with entryCategory="professional"
User->>FormDraggableAccordion: Click delete icon
FormDraggableAccordion-->>User: Open delete confirmation modal
User->>FormDraggableAccordion: Confirm deletion
FormDraggableAccordion-->>User: Entry deleted
Possibly related issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- apps/redi-talent-pool/src/components/organisms/jobseeker-profile-editables/EditableEducation.tsx (1 hunks)
- apps/redi-talent-pool/src/components/organisms/jobseeker-profile-editables/EditableProfessionalExperience.tsx (1 hunks)
- libs/shared-atomic-design-components/src/lib/atoms/FormDraggableAccordion.tsx (4 hunks)
Additional comments not posted (8)
libs/shared-atomic-design-components/src/lib/atoms/FormDraggableAccordion.tsx (6)
9-9: Import statement forLightModalis correct.The import statement for
LightModalis necessary for the new modal functionality.
17-17: Addition ofentryCategoryprop is correct.The
entryCategoryprop has been added to thePropsinterface to support the new modal functionality.
26-26: Usage ofentryCategoryprop in function parameters is correct.The
entryCategoryprop has been added to the function parameters to support the new modal functionality.
29-35: State management for delete confirmation modal is correct.The state management for the delete confirmation modal is well-implemented and necessary for the new functionality.
46-53: Rendering logic for modal's content is correct.The rendering logic for the modal's content is well-implemented and necessary for the new functionality.
72-82: Integration of modal with the component is correct.The integration of the modal with the component enhances the user experience by providing a confirmation step before deletion.
apps/redi-talent-pool/src/components/organisms/jobseeker-profile-editables/EditableEducation.tsx (1)
399-399: Addition ofentryCategoryprop is correct.The
entryCategoryprop with the value"education"has been added to theJobseekerFormSectionEducationcomponent to support the new modal functionality.apps/redi-talent-pool/src/components/organisms/jobseeker-profile-editables/EditableProfessionalExperience.tsx (1)
397-397: Addition ofentryCategoryprop is correct.The
entryCategoryprop with the value"professional"has been added to theJobseekerFormSectionProfessionalExperiencecomponent to support the new modal functionality.
…r reflect its purpose and ensure consistency.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- libs/shared-atomic-design-components/src/lib/atoms/FormDraggableAccordion.tsx (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- libs/shared-atomic-design-components/src/lib/atoms/FormDraggableAccordion.tsx
|
Dear @helloanil, this is a kind reminder |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- apps/redi-talent-pool/src/components/organisms/jobseeker-profile-editables/EditableEducation.tsx (5 hunks)
- apps/redi-talent-pool/src/components/organisms/jobseeker-profile-editables/EditableProfessionalExperience.tsx (5 hunks)
- libs/shared-atomic-design-components/src/lib/atoms/FormDraggableAccordion.tsx (3 hunks)
Additional comments not posted (9)
libs/shared-atomic-design-components/src/lib/atoms/FormDraggableAccordion.tsx (3)
16-16: The addition of theentryCategoryproperty looks good.The
entryCategoryproperty enhances the flexibility of the component.
37-44: The usage ofentryCategoryto set modal messages looks good.The conditional logic for
modalHeadlineandmodalMessagebased onentryCategoryis clear and enhances the user experience.
25-25: The usage ofentryCategoryin the JSX looks good.Passing
entryCategoryas a prop ensures that the correct modal messages are displayed.apps/redi-talent-pool/src/components/organisms/jobseeker-profile-editables/EditableEducation.tsx (3)
164-166: The addition of theeducationIdToRemovestate variable looks good.This state variable is necessary for managing the modal state.
370-370: The modification to theonRemovefunction looks good.Setting
educationIdToRemoveto the ID of the entry being removed is necessary for triggering the modal.
498-506: The addition of theLightModalfor deletion confirmation looks good.This addition enhances the user experience by preventing accidental deletions.
apps/redi-talent-pool/src/components/organisms/jobseeker-profile-editables/EditableProfessionalExperience.tsx (3)
179-181: The addition of theexperienceIdToRemovestate variable looks good.This state variable is necessary for managing the modal state.
368-368: The modification to theonRemovefunction looks good.Setting
experienceIdToRemoveto the ID of the entry being removed is necessary for triggering the modal.
495-503: The addition of theLightModalfor deletion confirmation looks good.This addition enhances the user experience by preventing accidental deletions.
|
Hey, I just pushed b7f7a05 to master to remove some dead code this PR introduced (neither
|
What Github issue does this PR relate to? Insert link.
ticket 903
What should the reviewer know?
Overview:
This update enhances the FormDraggableAccordion component with improved modal functionality for deletion confirmation.
Details:
entryCategoryprop to theFormDraggableAccordioncomponent. This prop can be used to specify the type of entry (e.g., 'professional' or 'education').entryCategory.openDeleteModalandcloseDeleteModalto manage the state of the modal.LightModalcomponent to confirm deletion, using theentryCategoryto determine the appropriate text.entryCategoryoptional.Summary by CodeRabbit
New Features
Bug Fixes