Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToDos: replace looped subsetVector with subsetDT #5264

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

ben-schwen
Copy link
Member

Towards #678

@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #5264 (8c06744) into master (96860f2) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5264      +/-   ##
==========================================
- Coverage   99.50%   99.50%   -0.01%     
==========================================
  Files          77       77              
  Lines       14603    14599       -4     
==========================================
- Hits        14531    14527       -4     
  Misses         72       72              
Impacted Files Coverage Δ
R/data.table.R 99.89% <100.00%> (-0.01%) ⬇️
R/setops.R 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96860f2...8c06744. Read the comment docs.

@mattdowle mattdowle added this to the 1.14.3 milestone Dec 3, 2021
@mattdowle mattdowle merged commit 2ef323c into master Dec 3, 2021
@mattdowle mattdowle deleted the todo_looped_vectorSubset branch December 3, 2021 18:58
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants