Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #2986; fread:select was sorting integers incorrectly #2987

Merged
merged 2 commits into from
Aug 11, 2018
Merged

Closes #2986; fread:select was sorting integers incorrectly #2987

merged 2 commits into from
Aug 11, 2018

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Jul 26, 2018 •
edited by mattdowle
Loading

Tagging @arunsrinivasan since he filed the initial select-sorting fix.

@HughParsonage
Copy link
Member

I believe #2545 also closes this. See also #1445.

@MichaelChirico
Copy link
Member Author

@HughParsonage OK cool, good to know. Will close this if that merges first 👍

@mattdowle mattdowle added this to the 1.11.6 milestone Aug 11, 2018
@mattdowle mattdowle merged commit 4aa8d67 into master Aug 11, 2018
@mattdowle mattdowle deleted the fread_select_order branch August 11, 2018 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunsrinivasan arunsrinivasan Awaiting requested review from arunsrinivasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11.6
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelChirico @HughParsonage @mattdowle