Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto enable merge 4 #12

Merged
merged 8 commits into from
Aug 21, 2024
Merged

Auto enable merge 4 #12

merged 8 commits into from
Aug 21, 2024

Conversation

Rd4dev
Copy link
Owner

@Rd4dev Rd4dev commented Aug 21, 2024

Explanation

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@Rd4dev Rd4dev enabled auto-merge August 21, 2024 03:07
Copy link

Coverage Report

Results

Number of files assessed: 4
Overall Coverage: 15.64%
Coverage Analysis: FAIL

Failing coverage

File Coverage Lines Hit Status Min Required
ComputeAabDifferences.ktscripts/src/java/org/oppia/android/scripts/apkstats/ComputeAabDifferences.kt
5.46% 19 / 348 6% *

* represents tests with custom overridden pass/fail coverage thresholds

Passing coverage

Files with passing code coverage
File Coverage Lines Hit Status Min Required
TestFileCheck.ktscripts/src/java/org/oppia/android/scripts/testfile/TestFileCheck.kt
100.00% 42 / 42 70%

Exempted coverage

Files exempted from coverage
File Exemption Reason
ActivityComponent.ktapp/src/main/java/org/oppia/android/app/activity/ActivityComponent.kt
This file is exempted from having a test file; skipping coverage check.
HomeActivity.ktapp/src/main/java/org/oppia/android/app/home/HomeActivity.kt
This file is incompatible with code coverage tooling; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

Copy link

Coverage Report

Results

Number of files assessed: 3
Overall Coverage: 100.00%
Coverage Analysis: PASS

Passing coverage

Files with passing code coverage
File Coverage Lines Hit Status Min Required
TestFileCheck.ktscripts/src/java/org/oppia/android/scripts/testfile/TestFileCheck.kt
100.00% 42 / 42 70%

Exempted coverage

Files exempted from coverage
File Exemption Reason
ActivityComponent.ktapp/src/main/java/org/oppia/android/app/activity/ActivityComponent.kt
This file is exempted from having a test file; skipping coverage check.
HomeActivity.ktapp/src/main/java/org/oppia/android/app/home/HomeActivity.kt
This file is incompatible with code coverage tooling; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

@Rd4dev Rd4dev merged commit 48f7ad6 into develop Aug 21, 2024
25 checks passed
@Rd4dev Rd4dev deleted the auto-enable-merge-4 branch August 21, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants