Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing US to ticker in one Equity example #368

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

eddelbuettel
Copy link
Member

As noted in #366 / #367 discussion. Do we have any other examples showing a (US) stock with the US ticker?

@johnlaing
Copy link
Contributor

There's another one just a few lines below in the same file.

Also potentially here:

std::string tickerValue = datapoint.getValueAsString() + std::string(" Equity");

Though I'm not quite sure what it's doing, so perhaps best to leave alone.

@eddelbuettel
Copy link
Member Author

Line 142 is tricky. Maybe ticker is 'GOOG US'? It is also a conditional use, and the example in beqs.R uses non-ticker values :-/ Probably best to be left alone.

I adjusted the commit to README.md. Thanks for catching that. Not enough early morning coffee.

@johnlaing johnlaing merged commit 2db5b41 into master Jul 7, 2022
@eddelbuettel eddelbuettel deleted the feature/equity_example branch July 7, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants