Fix BDS segfault #347
Merged
Fix BDS segfault #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…segfaults probably caused by garbage collection from unprotected SEXP
|
Thanks for reworking this. We work by an informal "majority of guilty parties onboard" rule so I will wait for either @johnlaing or @armstrtw to pipe in but this is otherwise fine by me. |
|
I like the new patch. It's minimally invasive. Please do keep the test code in your own branch. It will be useful to resurrect if any additional bugs surface later on. |
|
@armstrtw Can you maybe hit the approve button for the code review? I just did the same, but it would be good if we had two (or more) "formal" hand shakes on this. |
armstrtw
approved these changes
Dec 3, 2021
eddelbuettel
added a commit
that referenced
this pull request
Dec 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix BDS crashes from #253