#33 - Display GitHub input when the user is Graduate - Sabella #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sabella-8
changed the title
taiwo2
reviewed
Jul 25, 2024
| @@ -8,6 +8,7 @@ const SignUp = () => { | |||
| const [userType, setUserType] = useState("graduate"); | |||
| const [message, setMessage] = useState(""); | |||
| const [isGraduate, setIsGraduate] = useState(true); | |||
| const [userGithub, setUserGithub] = useState(""); | |||
|
|
||
| router.post("/users", async (req, res) => { | ||
| const { username, passwordHash, userType } = req.body; | ||
| router.post("/users", async (req, res) => { |
There was a problem hiding this comment.
this should be signup by name not users
taiwo2
reviewed
Jul 25, 2024
| router.post("/users", async (req, res) => { | ||
| const { username, passwordHash, userType } = req.body; | ||
| router.post("/users", async (req, res) => { | ||
| const { username, passwordHash, userType, userGithub } = req.body; |
There was a problem hiding this comment.
Kindly use bcrypt to hash the password from the backend, not the frontend
|
Hello, @taiwo2, thank you for your comment. However, the comment you provided is related to the previous work, which I did not do. I only added the GitHub input when users choose "graduate" in the options. |
fikretellek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming Rules
Name your PR like this: ISSUENUMBER-TITLE-YOURNAME
Description
Write a summary of your change. Explain why you have made it.
Related to
Make sure you include the issue number with a hash sign # so Github can link this PR to the right issue, like this:
Fixes CodeYourFuture#1
Checklist: