NW6| Rabia Avci | React Module Project | Feature Deck - Week1 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ara225
reviewed
Mar 3, 2024
| return ( | ||
| <div className="deck"> | ||
| {cardsData.map((cardData, i) => ( | ||
| <Card title={cardData.title} url={cardData.url} image={cardData.image} key={i} /> |
There was a problem hiding this comment.
Good work with the props :)
This doesn't really matter in this situation (it would only really matter when you're dealing with large amounts of components), but the key shouldn't really be an index. Have a read through the section here under "Keeping List Items in Order with Key" https://react.dev/learn/rendering-lists
There was a problem hiding this comment.
yes, id would be better solution 👍 Thank you!
| const cardElement = cards[index]; | ||
| expect(cardElement).toHaveTextContent(cardData.title); | ||
| expect(cardElement.querySelector("a")).toHaveAttribute("href", cardData.url); | ||
| expect(cardElement.querySelector("img")).toHaveAttribute("src", cardData.image); |
zelihapala
approved these changes
Mar 5, 2024
| return ( | ||
| <div className="deck"> | ||
| {cardsData.map((cardData, i) => ( | ||
| <Card title={cardData.title} url={cardData.url} image={cardData.image} key={i} /> |
✅ Deploy Preview for cyf-react-hotel-project ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed Deck component with 3 cards component(which data comes from fakeCards.json). Added tests for Deck feature.
I would be very happy if you review my code, comment and approve it.