#212 - Multi-threaded NoiseMapBuilder with Rayon [WIP] #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ameobea
reviewed
Sep 20, 2019
| @@ -9,12 +9,16 @@ license = "Apache-2.0/MIT" | |||
| keywords = ["math", "random"] | |||
| authors = ["The Noise-rs Developers."] | |||
|
|
|||
| [profile.release] | |||
There was a problem hiding this comment.
Do we want to leave this in? Enabling debug in release builds is useful for debugging and benchmarking, but it can create release binaries that are very large.
Also, I don't actually know if this has any effect for libraries.
There was a problem hiding this comment.
Definitely didn't mean to commit that, feel free to remove.
Razaekel
changed the title
Razaekel
force-pushed
the
develop
branch
3 times, most recently
from
4157bee
to
7ad5b86
Compare
|
Does this have a chance to land? It's exactly what I was looking for and it looks like a really nice improvement. |
|
Is this PR still in active development? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.