Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typo): fix wrong greeter_y_expr and typo error message in arguments parser. #237

Merged
merged 1 commit into from
Sep 11, 2021
Merged

fix(typo): fix wrong greeter_y_expr and typo error message in arguments parser. #237

merged 1 commit into from
Sep 11, 2021

Conversation

cmsxbc
Copy link

@cmsxbc cmsxbc commented Sep 10, 2021

Some typo in arguments parser.

Description

  1. typo in greeter_y_expr, make greeter position wrong
  2. typo in error messages of --greeter-pos and --wrong-pos

Screenshots/screencaps

Release notes

Notes:

Raymo111
Raymo111 approved these changes Sep 11, 2021
View reviewed changes
Copy link
Owner

@Raymo111 Raymo111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@Raymo111 Raymo111 merged commit d78d220 into Raymo111:master Sep 11, 2021
@cmsxbc cmsxbc deleted the fix_greeter_wrong_args branch September 11, 2021 07:58
@github-actions github-actions bot mentioned this pull request Sep 4, 2023
Closed
@github-actions github-actions bot mentioned this pull request Apr 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raymo111 Raymo111 Raymo111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmsxbc @Raymo111