Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of ledger.py in the binary electrum-rvn-3.3.8-rvn3-portable.exe for support of updated Bitcoin App 1.5.1 #5

Open
BusterTheFerret opened this issue Mar 9, 2021 · 8 comments
Open

Implementation of ledger.py in the binary electrum-rvn-3.3.8-rvn3-portable.exe for support of updated Bitcoin App 1.5.1 #5

BusterTheFerret opened this issue Mar 9, 2021 · 8 comments

Comments

@BusterTheFerret
Copy link

URL's:
https://github.com/standard-error/electrum-raven/issues/22
https://github.com/standard-error/electrum-raven/pull/23/files
https://github.com/standard-error/electrum-raven/releases/
https://github.com/RavencoinFoundation/electrum-raven/tree/master/electrum/plugins/ledger

Hi RavencoinFoundation,

First, I'n not sure if I'm posting wrongly here. It is a frok of bitcoin and it is the electrum, right???

Anyway. I believe you are the guys which developed the Ravencoin IOS wallet to right? I've been using it so far, but since I've been having issues on my iPad with that wallet (Not syncing/not sure if iPad is the reason) I'm trying to get the Ledger and the electrum-rvn-3.3.8-rvn3-portable to work again. Because of the issue with my IOS wallet but also because I've got a lot of Ravencoins on the Ledger/electrum-rvn... wallet.
I've been posting on https://github.com/standard-error/electrum-raven/issues/22 regarding this for 3 months. The developer doesn't do much so others have had to step in. The best of them is 3rdliteration which has been very helpful, but still I haven't been able to solve the issue. The reason is that I'm not as advanced in programming as these guys and I'm afraid to ruin more than already is. I know what the issue is, it's the ledger.py file that needs to be replaced with the text .... Blue app-bitcoin >= 1.5.1 etc. etc. line 561 - 568. Haven't succeeded in editing the ledger.py file on myself, but 3rdliteration explained that you already implemented the fix into a new ledger.py. But, hasn't made a binary yet. Therefore I'm asking if you would make this implementation? I believe the electrum wallet is open source so it should be possible right?

I'm a huge supporter of ravencoin, on Youtube channels, forums etc the last 2 years under my alias DanTheDane. I hope you will/can help me and others that have exactly the same issue. Thx in advance.

Kind Regards,
Dan
@Rcmining
Copy link

Hi, here i have a solution for the issue of ledger nano with electrum-rvn, i hope to be helpful
https://twitter.com/RC_Mining/status/1363298738723295232?s=20
https://github.com/RainbowMiner/miner-binaries/releases/tag/v3.3.8-rvn3-fixed

@BusterTheFerret
Copy link
Author

Hi, here i have a solution for the issue of ledger nano with electrum-rvn, i hope to be helpful
https://twitter.com/RC_Mining/status/1363298738723295232?s=20
https://github.com/RainbowMiner/miner-binaries/releases/tag/v3.3.8-rvn3-fixed

Hi RC mining,

Thx buddy... I've seen the binary from RainbowMiner and it's nothing personal, I just can't use a binary from a completely new GIT'er .
I'll check the link on twitter.

Thx again!

KR
Dan

@BusterTheFerret
Copy link
Author

BusterTheFerret commented Mar 22, 2021 •
edited
Loading

Hi, here i have a solution for the issue of ledger nano with electrum-rvn, i hope to be helpful
https://twitter.com/RC_Mining/status/1363298738723295232?s=20
https://github.com/RainbowMiner/miner-binaries/releases/tag/v3.3.8-rvn3-fixed

Hi RC-mining,

Decided to do as you and try the binary from RainbowMiner. The wallet runs, but it's not connected it writes. Not to the server, not to the Ledger apparently

image

Any suggestions. I'll donate to both you and rainbow if you'll be able to help and solve this. And it's not chumpchange I'm talking about. Got 15.000RVN on it. For me, that's a lot..

Lower left corner "Ikke forbundet" is danish for Not Connected...
Both symbols in the lower right corner is red. Server not connected, Ledger same thing apparently.

Installing the binary, what did you choose? I'm running the portable version. "standard wallet", "Hardware device", but what about derivation path? Did you chose legacy or the path prompted beneath? Encryption/No encryption?

Thx..

@BusterTheFerret
Copy link
Author

Now it's connected to Ledger, but not connected to server...

image

@Rcmining
Copy link

Rcmining commented Mar 22, 2021 via email

@BusterTheFerret
Copy link
Author

BusterTheFerret commented Mar 23, 2021 •
edited
Loading

Hi friend Make sure that you are downloading the correct file, attached a picture to show you which is the file, and go on the steps to connect the ledger and upload your rvn wallet. OK RC
…

Hi again,

I can't see you image... Sadly, but I'm pretty sure I used the right file since its the same as standard-errors, only with an added "dirty" to the filename LOL

I used the fixed binarys from RainbowMiners git:
https://github.com/RainbowMiner/miner-binaries/releases/tag/v3.3.8-rvn3-fixed

I tried:
"electrum-rvn-3.3.8-rvn3-dirty-portable.exe"
"electrum-rvn-3.3.8-rvn3-dirty.exe"
"electrum-rvn-3.3.8-rvn3-dirty-setup.exe"

Non worked. I was able to open the wallet, and connect to the Ledger, but it wouldn't sync. Not Connected To Electrum Servers...

image
image
image

https://user-images.githubusercontent.com/45902769/112073098-a0c99f00-8b73-11eb-9b91-d7b054f14b81.png

Transaction done, both of them..
image

I'm able to connect to the Ledger using my laplop where it was originally installed, but I can only see the first transaction. I never got to sync it before I updated the Bitcoin App 1.5.1 which made all the problems. And now it will not connect to servers. Theres still something wrong with that wallet, but I can see the first transaction in the wallet which now opens, because of RainbowMiner,. So I really hope I can get it to connect to the electrum servers somehow.

@Rcmining
Copy link

Rcmining commented Mar 23, 2021 via email

@Rcmining
Copy link

Rcmining commented Mar 23, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rcmining @BusterTheFerret