Skip to content

Commit

Permalink
Use .go-version to get Kubernetes go version
Browse files Browse the repository at this point in the history
Kubernetes publishes .go-version since v1.23. Use it to get Kubernete's go
version instead of parsing a shell script.
  • Loading branch information
jsafrane committed Feb 21, 2024
1 parent b54c1ba commit e681b17
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion prow.sh
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,15 @@ go_version_for_kubernetes () (
local version="$2"
local go_version

# We use the minimal Go version specified for each K8S release (= minimum_go_version in hack/lib/golang.sh).
# Try to get the version for .go-version
go_version="$( cat "$path/.go-version" )"
if [ "$go_version" ]; then
echo "$go_version"
return
fi

# Fall back to hack/lib/golang.sh parsing.
# This is necessary in v1.26.0 and older Kubernetes releases that do not have .go-version.
# More recent versions might also work, but we don't want to count on that.
go_version="$(grep minimum_go_version= "$path/hack/lib/golang.sh" | sed -e 's/.*=go//')"
if ! [ "$go_version" ]; then
Expand Down

0 comments on commit e681b17

Please sign in to comment.