Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused files and assets config #95

Merged
merged 3 commits into from
Dec 9, 2022
Merged

Remove unused files and assets config #95

merged 3 commits into from
Dec 9, 2022

Conversation

patch0
Copy link
Contributor

@patch0 patch0 commented Dec 9, 2022 •
edited
Loading

The API doesn't need any asset logic, or serving up of assets, aside from the S3 stuff which is not part of the assets pipeline.

What's changed

  • Removed old sense hat/p5/pygal js libs
  • Remove config for asset handling, and turbo, stimulus, and sprockets gems

@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-remove-unu-wcy6gj December 9, 2022 12:16 Inactive
@raspberrypigithubbot
Copy link

@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-remove-unu-wxqdvh December 9, 2022 15:32 Inactive
@raspberrypigithubbot
Copy link

@patch0 patch0 marked this pull request as ready for review December 9, 2022 15:58
loiswells97
loiswells97 approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@loiswells97 loiswells97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to get rid of all this stuff 👋

@patch0 patch0 merged commit 58a5e0d into main Dec 9, 2022
@patch0 patch0 deleted the remove-unused-files branch December 9, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loiswells97 loiswells97 loiswells97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patch0 @raspberrypigithubbot @loiswells97 @raspberrypiherokubot