Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker container #91

Merged
merged 4 commits into from
Dec 1, 2022
Merged

Update docker container #91

merged 4 commits into from
Dec 1, 2022

Conversation

patch0
Copy link
Contributor

@patch0 patch0 commented Dec 1, 2022

This builds the Docker container in the same way as codeclub, coderdojo-frontend, clubs-api, showcase etc.

It should handle multi-arch Gemfiles just fine.

No ports have changed.

The entrypoint file has been removed.

NB The docker-compose container has been renamed from web to api.

@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-update-doc-hpobrm December 1, 2022 11:54 Inactive
@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-update-doc-jheorz December 1, 2022 14:03 Inactive
@raspberrypigithubbot
Copy link

Copy link
Contributor

@loiswells97 loiswells97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I fully understand what's going on, but I think I've got the gist and it looks good to me 👍

@patch0 patch0 merged commit 5da71c2 into main Dec 1, 2022
@patch0 patch0 deleted the update-docker-container branch December 1, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants