Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent null or duplicate phrase identifiers for projects being inserted into the database #7

Conversation

create-issue-branch[bot]
Copy link
Contributor

closes #5

@loiswells97 loiswells97 marked this pull request as ready for review January 11, 2022 12:24
Copy link
Contributor

@ArayB ArayB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments on things to look at.

app/models/project.rb Outdated Show resolved Hide resolved
spec/models/project_spec.rb Outdated Show resolved Hide resolved
db/migrate/20211220155302_create_projects.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@ArayB ArayB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loiswells97 loiswells97 merged commit eb34216 into main Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent null or duplicate phrase identifiers for projects being inserted into the database
2 participants