Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Delete, Update mutations #139

Merged
merged 9 commits into from
Mar 2, 2023
Merged

Add Delete, Update mutations #139

merged 9 commits into from
Mar 2, 2023

Conversation

patch0
Copy link
Contributor

@patch0 patch0 commented Mar 1, 2023

What's changed?

  • UpdateProject mutation allows the name and type of project to be changed (nothing else though)
  • DeleteProject mutation destroys a project
  • CreateProject mutation has had its input type refactored to be More GraphQL(tm)

This is required by editor-ui#376

@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-add-update-inzxsn March 1, 2023 17:04 Inactive
@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-add-update-inzxsn March 1, 2023 17:04 Inactive
@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-add-update-inzxsn March 1, 2023 17:11 Inactive
@patch0 patch0 marked this pull request as ready for review March 1, 2023 17:11
@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-add-update-inzxsn March 1, 2023 17:12 Inactive
@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-add-update-inzxsn March 1, 2023 17:19 Inactive
@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-add-update-inzxsn March 2, 2023 09:50 Inactive
@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-add-update-inzxsn March 2, 2023 09:52 Inactive
Copy link
Contributor

@IzzySmillie IzzySmillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

I guess in the future we'll need to extend on the update mutation to also be able update any components as well.

@@ -3,15 +3,10 @@
module Mutations
class CreateProject < BaseMutation
description 'A mutation to create a new project'
input_object_class Types::CreateProjectInputType
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oo this is nicer 👀

@patch0 patch0 merged commit b2b730f into main Mar 2, 2023
@patch0 patch0 deleted the add-update-delete-mutations branch March 2, 2023 14:07
patch0 added a commit to RaspberryPiFoundation/editor-ui that referenced this pull request Mar 2, 2023
## What's changed?

* Adds apollo-client, graphql packages
* Removes useProjectList hook]
* Fetches ProjectIndex data using GraphQL API, with fragments for
pagination, project list item etc.
* Uses GraphQL API for DeleteProject and RenameProject modals

## Points for consideration

* When renaming a project the list doesn't get re-sorted by "updated at"
time
* We're sorta changing state without telling Redux

## Before deployment


[editor-api#139](RaspberryPiFoundation/editor-api#139)
needs merging

---------

Co-authored-by: Izzy Smillie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants