-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Delete, Update mutations #139
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raspberrypiherokubot
temporarily deployed
to
editor-api-p-add-update-inzxsn
March 1, 2023 17:04
Inactive
raspberrypiherokubot
temporarily deployed
to
editor-api-p-add-update-inzxsn
March 1, 2023 17:04
Inactive
raspberrypiherokubot
temporarily deployed
to
editor-api-p-add-update-inzxsn
March 1, 2023 17:11
Inactive
raspberrypiherokubot
temporarily deployed
to
editor-api-p-add-update-inzxsn
March 1, 2023 17:12
Inactive
…oundation/choco-cake into add-update-delete-mutations
raspberrypiherokubot
temporarily deployed
to
editor-api-p-add-update-inzxsn
March 1, 2023 17:19
Inactive
raspberrypiherokubot
temporarily deployed
to
editor-api-p-add-update-inzxsn
March 2, 2023 09:50
Inactive
raspberrypiherokubot
temporarily deployed
to
editor-api-p-add-update-inzxsn
March 2, 2023 09:52
Inactive
IzzySmillie
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
I guess in the future we'll need to extend on the update mutation to also be able update any components as well.
@@ -3,15 +3,10 @@ | |||
module Mutations | |||
class CreateProject < BaseMutation | |||
description 'A mutation to create a new project' | |||
input_object_class Types::CreateProjectInputType |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oo this is nicer 👀
patch0
added a commit
to RaspberryPiFoundation/editor-ui
that referenced
this pull request
Mar 2, 2023
## What's changed? * Adds apollo-client, graphql packages * Removes useProjectList hook] * Fetches ProjectIndex data using GraphQL API, with fragments for pagination, project list item etc. * Uses GraphQL API for DeleteProject and RenameProject modals ## Points for consideration * When renaming a project the list doesn't get re-sorted by "updated at" time * We're sorta changing state without telling Redux ## Before deployment [editor-api#139](RaspberryPiFoundation/editor-api#139) needs merging --------- Co-authored-by: Izzy Smillie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
UpdateProject
mutation allows the name and type of project to be changed (nothing else though)DeleteProject
mutation destroys a projectCreateProject
mutation has had its input type refactored to be More GraphQL(tm)This is required by editor-ui#376