-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor project creation out of rake task #127
Merged
loiswells97
merged 22 commits into
main
from
issues/126-Refactor_project_creation_out_of_rake_task
Feb 17, 2023
Merged
Refactor project creation out of rake task #127
loiswells97
merged 22 commits into
main
from
issues/126-Refactor_project_creation_out_of_rake_task
Feb 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
raspberrypiherokubot
temporarily deployed
to
editor-api-p-issues-126-cy28at
February 10, 2023 11:44
Inactive
raspberrypiherokubot
temporarily deployed
to
editor-api-p-issues-126-ywqbql
February 10, 2023 16:05
Inactive
raspberrypiherokubot
temporarily deployed
to
editor-api-p-issues-126-yhp88n
February 10, 2023 17:03
Inactive
raspberrypiherokubot
temporarily deployed
to
editor-api-p-issues-126-elywqn
February 10, 2023 17:29
Inactive
raspberrypiherokubot
temporarily deployed
to
editor-api-p-issues-126-tnjolc
February 10, 2023 17:37
Inactive
IzzySmillie
requested changes
Feb 16, 2023
…into rake-task-testing
- Adds a `ProjectImporter` call to rake test
IzzySmillie
previously approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
IzzySmillie
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦭
loiswells97
deleted the
issues/126-Refactor_project_creation_out_of_rake_task
branch
February 17, 2023 10:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed?
index
fromcomponent
modelProjectImporter
to handleproject
creation in the databaseprojects:create_starter
rake task to format data and callProjectImporter#import!
instead of saving directly to databaseprojects:create_starter
rake task to only useNAME
,IDENTIFIER
andTYPE
from theproject_config.yml
and extract the component and image data solely from the file systemcloses #126