Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor project creation out of rake task #127

Merged

Conversation

create-issue-branch[bot]
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented Feb 10, 2023

What's Changed?

  • Remove index from component model
  • Order components alphabetically but with default component first
  • Create ProjectImporter to handle project creation in the database
  • Refactor projects:create_starter rake task to format data and call ProjectImporter#import! instead of saving directly to database
  • Also refactor projects:create_starter rake task to only use NAME, IDENTIFIER and TYPE from the project_config.yml and extract the component and image data solely from the file system

closes #126

@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-issues-126-cy28at February 10, 2023 11:44 Inactive
@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-issues-126-ywqbql February 10, 2023 16:05 Inactive
@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-issues-126-yhp88n February 10, 2023 17:03 Inactive
@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-issues-126-elywqn February 10, 2023 17:29 Inactive
@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-issues-126-tnjolc February 10, 2023 17:37 Inactive
@loiswells97 loiswells97 marked this pull request as ready for review February 16, 2023 12:51
spec/tasks/create_starter_spec.rb Outdated Show resolved Hide resolved
spec/tasks/create_starter_spec.rb Show resolved Hide resolved
IzzySmillie
IzzySmillie previously approved these changes Feb 17, 2023
Copy link
Contributor

@IzzySmillie IzzySmillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Copy link
Contributor

@IzzySmillie IzzySmillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭

@loiswells97 loiswells97 merged commit 30faf66 into main Feb 17, 2023
@loiswells97 loiswells97 deleted the issues/126-Refactor_project_creation_out_of_rake_task branch February 17, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor project creation out of rake task
4 participants