Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rake task for the archery project #11

Merged
merged 20 commits into from
Feb 11, 2022

Conversation

create-issue-branch[bot]
Copy link
Contributor

closes #10

@loiswells97 loiswells97 marked this pull request as ready for review February 9, 2022 13:43
@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

@patch0 patch0 marked this pull request as draft February 11, 2022 10:15
@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

@loiswells97 loiswells97 marked this pull request as ready for review February 11, 2022 12:55
Copy link
Contributor

@ArayB ArayB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of little things to amend.

I'm actually thinking now that maybe we could make more use of the metadata file. The file could define the components and their index to mean less munging of data in the rake task.

Maybe switching that config file to be json and using hashes and arrays.

app/controllers/api/projects/phrases_controller.rb Outdated Show resolved Hide resolved
lib/tasks/projects.rake Outdated Show resolved Hide resolved
@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

Copy link
Contributor

@ArayB ArayB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loiswells97 loiswells97 merged commit 8e6618e into main Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rake task for the archery project
3 participants