-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds minimal SD card write support to installer #1319
Conversation
Resolves #306 |
Filesystem
Memory use
pre minwrite % post minwrite % Disk I/O
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@billz The implemenation look good to me, but I have currently no chance to test it (on vacation right now), but could do it next week.
Some comments wrt minwrite.sh:
- I am not sure, why
triggerhappy
is uninstalled (function_remove_packages
). I assume its just a relict from my investigation of read-only systems. Likely not needed here, since we assume a headless system. - I assume you checked, that the all the disabled services (function
_disable_services
) are actually existing. In principle I would opt to ignore a not existing services. - Concerning to disable the service
console-setup
: this again might not be needed here. Makes sense for read-only systems.
@zbchristian many thanks for the feedback. enjoy your holiday :) |
Essentially wraps @zbchristian's contribution and integrates it into the Quick Installer.