refactor interpreter usage in story visualization
#9821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wochinge
commented
Oct 7, 2021
| else: | ||
| message = el.parse_data | ||
| message[TEXT] = f"{INTENT_MESSAGE_PREFIX}{el.intent_name}" |
There was a problem hiding this comment.
previously (even on 2.8.x) it always used None for the nodes which is super bad UX
wochinge
commented
Oct 7, 2021
| @@ -22,40 +21,6 @@ def test_load_training_data_reader_not_found_throws(tmp_path: Path, domain: Doma | |||
| training.load_data(str(tmp_path), domain) | |||
|
|
|||
|
|
|||
| async def test_story_visualization(domain: Domain, tmp_path: Path): | |||
There was a problem hiding this comment.
moved them to the other visualization tests
wochinge
commented
Oct 7, 2021
Comment on lines
151
to
170
| def test_story_visualization_with_processor( | ||
| domain: Domain, tmp_path: Path, default_agent: Agent | ||
| ): | ||
| import rasa.shared.core.training_data.loading as core_loading | ||
|
|
||
| story_steps = core_loading.load_data_from_resource( | ||
| "data/test_yaml_stories/stories.yml", domain | ||
| ) | ||
| out_file = tmp_path / "graph.html" | ||
| generated_graph = visualization.visualize_stories( | ||
| story_steps, | ||
| domain, | ||
| processor=default_agent.processor, | ||
| output_file=str(out_file), | ||
| max_history=3, | ||
| should_merge_nodes=False, | ||
| ) | ||
|
|
||
| assert str(None) not in out_file.read_text() | ||
| assert "/affirm" in out_file.read_text() | ||
| assert len(generated_graph.nodes()) == 51 | ||
| assert len(generated_graph.edges()) == 56 | ||
|
|
||
|
|
||
| def test_story_visualization_with_training_data( | ||
| domain: Domain, tmp_path: Path, nlu_data_path: Text | ||
| ): | ||
| import rasa.shared.core.training_data.loading as core_loading | ||
|
|
||
| story_steps = core_loading.load_data_from_resource( | ||
| "data/test_yaml_stories/stories.yml", domain | ||
| ) | ||
| out_file = tmp_path / "graph.html" | ||
| test_text = "test text" | ||
| test_intent = "affirm" | ||
| generated_graph = visualization.visualize_stories( | ||
| story_steps, | ||
| domain, | ||
| output_file=str(out_file), | ||
| max_history=3, | ||
| should_merge_nodes=False, | ||
| nlu_training_data=TrainingData( | ||
| [Message({TEXT: test_text, INTENT: test_intent})] | ||
| ), | ||
| ) |
There was a problem hiding this comment.
I added them to test whether things work as expected
1 task
wochinge
force-pushed
the
origin/3.0-architecture-revamp/9766/story-visualization
branch
2 times, most recently
from
93e56ec to
a98044e
Compare
joejuzl
suggested changes
Oct 8, 2021
|
I'll actually drop the |
wochinge
force-pushed
the
origin/3.0-architecture-revamp/9766/story-visualization
branch
from
1785aaf to
0d89bc6
Compare
wochinge
force-pushed
the
origin/3.0-architecture-revamp/9766/story-visualization
branch
from
0d89bc6 to
fe32dfc
Compare
wochinge
force-pushed
the
origin/3.0-architecture-revamp/9766/story-visualization
branch
from
fe32dfc to
0cc0ac9
Compare
|
@joejuzl Do you have time to give this another review today? |
joejuzl
approved these changes
Oct 12, 2021
wochinge
deleted the
origin/3.0-architecture-revamp/9766/story-visualization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)