-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation workflow to only publish one version per major #9731
Conversation
@m-vdb Can you 👀 if you have a minute? I hope I got it right 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🎉 thanks a lot @tczekajlo ! I think there is one part missing, about running the docs script itself here, which is creating a new version of the docs for new majors only, not minors. I think we just need to update the two patterns and we should be good to go (at first sight 🤔 )
Signed-off-by: tczekajlo <[email protected]>
@tczekajlo before merging this PR, I will need to wrap-up this one (remaining step is to merge the 2.8 docs manually into 2.x). I'll put this up today and ask for a review from CSE. Another thing we'll need to do around the same time is disable the docs workflows on at least 2.7, 2.6 (mostly a safety measure, in case people push new tags there. I don't expect it, but....). I can take care of this and I'll ask a review from you if that's alright |
Co-authored-by: Maxime Vdb <[email protected]>
awesome 💯 @tczekajlo I will approve the PR and merge it once the |
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)