Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NGramFeaturizer as per deprecation warning #9488

Merged
merged 2 commits into from
Sep 2, 2021

Conversation

usc-m
Copy link
Contributor

@usc-m usc-m commented Aug 31, 2021

Proposed changes:

Status (please check what you already did):

  • checked documentation for forgotten references
  • updated the changelog (please check changelog for instructions)

This follows through on the deprecation warning previously occupying the module
@usc-m usc-m requested review from koernerfelicia and a team August 31, 2021 16:10
Copy link
Contributor

@koernerfelicia koernerfelicia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for getting this done 🚀

@usc-m usc-m enabled auto-merge September 1, 2021 10:57
@usc-m usc-m merged commit 0b63f4f into main Sep 2, 2021
@usc-m usc-m deleted the 9455/remove-ngramfeaturizer branch September 2, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.0 Deprecation Warning: Remove NGramFeaturizer component
2 participants