Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create issue token error in CI - model regression #9211

Merged
merged 12 commits into from
Jul 29, 2021
Merged

Fix create issue token error in CI - model regression #9211

merged 12 commits into from
Jul 29, 2021

Conversation

HotThoughts
Copy link
Contributor

@HotThoughts HotThoughts commented Jul 27, 2021 •
edited
Loading

The problem:

  • Report description from here is a multiline string that contains certain symbols (left quote, single quote). For multiline string in JavaScript, we can quote it use left quotes, but we have to make sure the string itself does not contain any left quotes or add a \ in front of `.

Proposed changes:

  • Fix the SyntaxError: Invalid or unexpected token error by replacing all left quotes with \`. See the workflow run and the created issue.

@HotThoughts HotThoughts marked this pull request as ready for review July 28, 2021 20:37
@HotThoughts HotThoughts self-assigned this Jul 28, 2021
@HotThoughts HotThoughts requested a review from tczekajlo July 28, 2021 20:37
tczekajlo
tczekajlo approved these changes Jul 29, 2021
View reviewed changes
Copy link

@tczekajlo tczekajlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎖️

@tczekajlo tczekajlo merged commit d3084a1 into main Jul 29, 2021
@tczekajlo tczekajlo deleted the fix-create-issue-token-error branch July 29, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tczekajlo tczekajlo tczekajlo approved these changes

Assignees

@HotThoughts HotThoughts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HotThoughts @tczekajlo