Add AWS CI to telemetry CI checks #9083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wochinge
approved these changes
Jul 9, 2021
Comment on lines
+75
to
+77
| "CODEBUILD_BUILD_ARN", | ||
| "CODEBUILD_BUILD_ID", | ||
| "CODEBUILD_BATCH_BUILD_IDENTIFIER", |
There was a problem hiding this comment.
why do we add all three? Would one be enough?
There was a problem hiding this comment.
I wasn't sure which one is always present 😅 the language in the documentation wasn't very specific.
There was a problem hiding this comment.
at least CODEBUILD_BUILD_ID and CODEBUILD_BUILD_ARN seem to overlap from the documentation, no?
There was a problem hiding this comment.
Oh yes, the ARN contains the ID 🙈 I've already merged main into the branch, would it be ok to keep this as it is?
|
Is there actually also one for gitlab? |
|
ah, that's covered by |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
telemetrymodule to improve tracking of all CI pipelines.Status (please check what you already did):
black(please check Readme for instructions)