Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best model checkpoint allows metrics to be equal to previous best if at least one metric improves #8875

Merged
merged 32 commits into from
Jun 14, 2021

Conversation

koernerfelicia
Copy link
Contributor

duplicate of #8467, redone to target correct branch

@koernerfelicia koernerfelicia requested a review from samsucik June 14, 2021 16:19
Copy link
Contributor

@samsucik samsucik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this! 🚀

@koernerfelicia koernerfelicia merged commit 48f727b into 2.7.x Jun 14, 2021
@koernerfelicia koernerfelicia deleted the 2.7.x-7286 branch June 14, 2021 16:58
koernerfelicia added a commit that referenced this pull request Jun 17, 2021
Apply suggestions from code review post merge of #8875
JEM-Mosig pushed a commit that referenced this pull request Jun 23, 2021
* add fix

* Best model checkpoint allows metrics to be equal to previous best if at least one metric improves (#8875)

* Best model checkpoint allows metrics to be equal to previous best if at least one metric improves
* Apply suggestions from code review
Co-authored-by: Sam Sucik <[email protected]>
* Fix checkpointing tests

* Apply suggestions from code review: formatting, debug cleanup, improved fixture use

* security update to tensorflow 2.3.3

* Don't evaluate entities if no entities present in test data (#8813)

* Write bugfix

* Fix `should_eval_entities`

* Update changelog

* Pass on density parameter in test

* Improve test

* prepared release of version 2.7.1

* Remove unneccessary Path casts

Co-authored-by: Daksh <[email protected]>
Co-authored-by: koernerfelicia <[email protected]>
Co-authored-by: koernerfelicia <[email protected]>
Co-authored-by: Ella Rohm-Ensing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants