-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Best model checkpoint allows metrics to be equal to previous best if at least one metric improves #8875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at least one metric improves
Co-authored-by: Sam Sucik <[email protected]>
samsucik
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this! 🚀
koernerfelicia
added a commit
that referenced
this pull request
Jun 17, 2021
Apply suggestions from code review post merge of #8875
JEM-Mosig
pushed a commit
that referenced
this pull request
Jun 23, 2021
* add fix * Best model checkpoint allows metrics to be equal to previous best if at least one metric improves (#8875) * Best model checkpoint allows metrics to be equal to previous best if at least one metric improves * Apply suggestions from code review Co-authored-by: Sam Sucik <[email protected]> * Fix checkpointing tests * Apply suggestions from code review: formatting, debug cleanup, improved fixture use * security update to tensorflow 2.3.3 * Don't evaluate entities if no entities present in test data (#8813) * Write bugfix * Fix `should_eval_entities` * Update changelog * Pass on density parameter in test * Improve test * prepared release of version 2.7.1 * Remove unneccessary Path casts Co-authored-by: Daksh <[email protected]> Co-authored-by: koernerfelicia <[email protected]> Co-authored-by: koernerfelicia <[email protected]> Co-authored-by: Ella Rohm-Ensing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
duplicate of #8467, redone to target correct branch