catch and convert all aio_pika connection exceptions #8712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
joejuzl
suggested changes
May 19, 2021
| @@ -34,6 +34,7 @@ async def create( | |||
| sqlalchemy.exc.OperationalError, | |||
| aio_pika.exceptions.AMQPConnectionError, | |||
| aiormq.exceptions.ChannelNotFoundEntity, | |||
| *aio_pika.exceptions.CONNECTION_EXCEPTIONS, | |||
There was a problem hiding this comment.
Are some of the errors above included in this?
There was a problem hiding this comment.
I've just double-checked, the errors above are not included in aio_pika.exceptions.CONNECTION_EXCEPTIONS.
changelog/8544.misc.md
Outdated
| @@ -0,0 +1 @@ | |||
| Catch and convert all `aio_pika` connection exceptions to subclass of `RasaException`. | |||
There was a problem hiding this comment.
Only in event broker creation right?
There was a problem hiding this comment.
Yup, that's where I traced the error in the Sentry stacktrace. I'll add this note to the changelog.
|
Can we please also ignore this one #8112 ? |
|
@wochinge Yup, the entire built-in |
joejuzl
approved these changes
May 19, 2021
|
Amazing 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)