Add verify stories and rules actions in domain to rasa data validate

[ancalita]

Proposed changes:

• Fix Does Rasa Data Validate not check Rules.yml/Stories.yml? #7799

Status (please check what you already did):

• added some tests for the functionality
• updated the documentation
• updated the changelog (please check changelog for instructions)
• reformat files using black (please check Readme for instructions)

[wochinge]

Where can I find a clear Definition of Done for the issue? It's unclear to me what items need to be covered.

[ancalita]

@wochinge Indeed, there is no clear Definition of Done in the issue, I worked my way through the problems listed on the issue thread, which were:

• verify that actions in both rules and stories are in the domain
• verify that form slots use the slots defined in the domain

There was mentioned something about adding validation for MultiProjectImporter but since that implements the TrainingDataImporter interface, I reasoned that the validator should work with it too so I don't need to action anything?
I can clarify Definition of Done in the issue thread, let me know what you think.

[wochinge]

There was mentioned something about adding validation for MultiProjectImporter but since that implements the TrainingDataImporter interface,

Unfortunately the usage of RasaFileImporter is hardcoded here. It would require replacing with this

[ancalita]

Unfortunately the usage of RasaFileImporter is hardcoded here. It would require replacing with this

In the end, I've decided that adding support for MultiProjectImporter should be tackled separately and prioritised accordingly once it's decided if to keep feature as experimental - I've quickly tested making the change you suggested but it leads to many failed tests in test_rasa_data.py because config is empty in these tests. WDYT?

[wochinge]

sounds good! Do you create a new issue or do we keep track of the remaining work in the old issue?

[wochinge]

what if it's a rule?

[ancalita]

It works for rules too, I can rephrase to 'stories or rules'?

[wochinge]

I believe there is also an attribute on the story steps which states which one it is. How about also including the story / rule name in the warning so the training story / rule is easier to find for them?

[ancalita]

I've had a look, but source_name attribute shows the entire path of the file, so instead I used block_name attribute to refer to the title of the story or rule. I'll push the changes once I amend the test assertions too :)

[ancalita]

sounds good! Do you create a new issue or do we keep track of the remaining work in the old issue?

I'll create a new issue for this.