Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for missing intent warnings when running rasa test #8388

Merged
merged 14 commits into from
May 18, 2021
Merged

Fix for missing intent warnings when running rasa test #8388

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6babee5
Fix for missing intent warnings when running rasa test
b-quachtran Apr 7, 2021
17a5a0c
Merge branch 'main' into rasa_test_missing_intent_warning
b-quachtran Apr 8, 2021
81d0461
Merge branch 'main' into rasa_test_missing_intent_warning
b-quachtran Apr 20, 2021
dd139d9
Added default domain file exist check
b-quachtran Apr 22, 2021
1c2006a
Merge branch 'main' into rasa_test_missing_intent_warning
b-quachtran Apr 22, 2021
0f7ded4
Set default domain path for test data importers
b-quachtran Apr 23, 2021
96e296b
Merge branch 'rasa_test_missing_intent_warning' of https://github.com…
b-quachtran Apr 23, 2021
e203058
Removed unused import
b-quachtran Apr 23, 2021
01cf7ca
Added changelog
b-quachtran Apr 23, 2021
c20f804
Added Agent model directory check
b-quachtran Apr 23, 2021
10f2980
Added unit test
b-quachtran May 11, 2021
7bc4adb
Merge branch 'main' into rasa_test_missing_intent_warning
b-quachtran May 11, 2021
089fd9b
Update tests/core/test_test.py
b-quachtran May 17, 2021
51736f7
Merge branch 'main' into rasa_test_missing_intent_warning
b-quachtran May 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/8388.bugfix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed bug where missing intent warnings appear when running `rasa test`
3 changes: 2 additions & 1 deletion rasa/cli/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
DEFAULT_MODELS_PATH,
DEFAULT_DATA_PATH,
DEFAULT_RESULTS_PATH,
DEFAULT_DOMAIN_PATH,
)
import rasa.shared.utils.validation as validation_utils
import rasa.cli.utils
Expand Down Expand Up @@ -158,7 +159,7 @@ async def run_nlu_test_async(

data_path = rasa.cli.utils.get_validated_path(data_path, "nlu", DEFAULT_DATA_PATH)
test_data_importer = TrainingDataImporter.load_from_dict(
training_data_paths=[data_path]
training_data_paths=[data_path], domain_path=DEFAULT_DOMAIN_PATH,
)
nlu_data = await test_data_importer.get_nlu_data()

Expand Down
13 changes: 12 additions & 1 deletion rasa/core/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,9 +372,20 @@ async def _create_data_generator(
use_conversation_test_files: bool = False,
) -> "TrainingDataGenerator":
from rasa.shared.core.generator import TrainingDataGenerator
from rasa.shared.constants import DEFAULT_DOMAIN_PATH
from rasa.model import get_model_subdirectories

core_model = None
if agent.model_directory:
core_model, _ = get_model_subdirectories(agent.model_directory)

if core_model and os.path.exists(os.path.join(core_model, DEFAULT_DOMAIN_PATH)):
domain_path = os.path.join(core_model, DEFAULT_DOMAIN_PATH)
else:
domain_path = None

test_data_importer = TrainingDataImporter.load_from_dict(
training_data_paths=[resource_name]
training_data_paths=[resource_name], domain_path=domain_path
b-quachtran marked this conversation as resolved.
Show resolved Hide resolved
)
if use_conversation_test_files:
story_graph = await test_data_importer.get_conversation_tests()
Expand Down
3 changes: 2 additions & 1 deletion rasa/nlu/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1439,13 +1439,14 @@ async def run_evaluation(
Returns: dictionary containing evaluation results
"""
import rasa.shared.nlu.training_data.loading
from rasa.shared.constants import DEFAULT_DOMAIN_PATH

# get the metadata config from the package data
interpreter = Interpreter.load(model_path, component_builder)

interpreter.pipeline = remove_pretrained_extractors(interpreter.pipeline)
test_data_importer = TrainingDataImporter.load_from_dict(
training_data_paths=[data_path]
training_data_paths=[data_path], domain_path=DEFAULT_DOMAIN_PATH,
)
test_data = await test_data_importer.get_nlu_data()

Expand Down