Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8114/handle entities with no start and end when writing stories 2.4.x #8299

Conversation

joejuzl
Copy link
Contributor

@joejuzl joejuzl commented Mar 25, 2021

Proposed changes:
Cherry pick of #8271 for 2.4.x

…8271)

* Ignore entities with no start or end when generating message texts

* review comments
@joejuzl joejuzl requested review from a team, federicotdn and wochinge and removed request for a team and federicotdn March 25, 2021 14:55
@joejuzl joejuzl linked an issue Mar 25, 2021 that may be closed by this pull request
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@joejuzl joejuzl enabled auto-merge (squash) March 25, 2021 14:56
@joejuzl joejuzl merged commit 791aee8 into 2.4.x Mar 25, 2021
@joejuzl joejuzl deleted the 8114/handle_entities_with_no_start_and_end_when_writting_stories_2 branch March 25, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConversationError when retrieving end-to-end story
2 participants