Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sanic docs link #8272

Merged
merged 4 commits into from
Mar 22, 2021
Merged

Fix sanic docs link #8272

merged 4 commits into from
Mar 22, 2021

Conversation

koaning
Copy link
Contributor

@koaning koaning commented Mar 22, 2021

There were some doc tests breaking because sanic moved their documentation. I noticed this while working on #7869.

This PR addresses the bad links on our docs.

@koaning koaning requested a review from wochinge March 22, 2021 12:25
@koaning koaning mentioned this pull request Mar 22, 2021
@koaning
Copy link
Contributor Author

koaning commented Mar 22, 2021

@wochinge I'm checking because I know the CI changed a lot recently. Is the Wait for docs tests bug something I need to worry about here? It feels like this is a CI thing that's breaking, not my change, but I could be mistaken.

Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@wochinge
Copy link
Contributor

weird - let's rerun

@wochinge wochinge mentioned this pull request Mar 22, 2021
4 tasks
@koaning koaning enabled auto-merge March 22, 2021 14:17
@koaning koaning merged commit 941a2a9 into main Mar 22, 2021
@koaning koaning deleted the fix-sanic-docs-link branch March 22, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants