-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimum compatible version to --version command #8184
Add minimum compatible version to --version command #8184
Conversation
Co-authored-by: Guilherme Mendes <[email protected]>
Thanks for submitting a pull request 🚀 @melindaloubser1 will take a look at it as soon as possible ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing!
Minor thing: Could you set the spacing so that the versions all line up like before? Right now it looks like this:
Rasa Version : 2.4.0
Minimum Compatible Version : 2.2.0a1
Rasa SDK Version : 2.4.0
Rasa X Version : None
Python Version : 3.7.4
something like this:
Rasa Version : 2.4.0
Minimum Compatible Version: 2.2.0a1
Rasa SDK Version : 2.4.0
Rasa X Version : None
Python Version : 3.7.4
Co-authored-by: Guilherme Mendes <[email protected]>
@melindaloubser1 done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
It says
This is because of a check introduced some months ago that requires docstrings be added to any new or changed functions.
|
rasa/__main__.py
Outdated
@@ -93,7 +93,7 @@ def print_version() -> None: | |||
|
|||
|
|||
def main() -> None: | |||
# Running as standalone python application | |||
"""Running as standalone python application""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"""Running as standalone python application""" | |
"""Run as standalone python application""" |
By convention we use the imperative
Proposed changes:
MINIMUM-COMPATIBLE-VERSION
to--version
command.rasa version's
output #7477Status (please check what you already did):
black
(please check Readme for instructions)