Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests which train model #8162

Merged
merged 25 commits into from
Mar 25, 2021
Merged

Improve tests which train model #8162

merged 25 commits into from
Mar 25, 2021

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Mar 10, 2021

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@alwx alwx changed the title Integration tests out of test_train.py Improve tests which train model Mar 10, 2021
@alwx alwx force-pushed the train-model-tests branch from 17a822c to c5bcaa1 Compare March 11, 2021 10:43
@alwx alwx requested a review from wochinge March 16, 2021 08:46
@alwx alwx marked this pull request as ready for review March 16, 2021 08:46
@alwx alwx mentioned this pull request Mar 17, 2021
Closed
wochinge
wochinge reviewed Mar 17, 2021
View reviewed changes
tests/core/test_agent.py Outdated Show resolved Hide resolved
tests/core/test_training.py Outdated Show resolved Hide resolved
tests/core/test_training.py Outdated Show resolved Hide resolved
tests/core/test_training.py Outdated Show resolved Hide resolved
tests/integration_tests/nlu/test_train.py Outdated Show resolved Hide resolved
tests/nlu/test_evaluation.py Outdated Show resolved Hide resolved
tests/nlu/test_evaluation.py Outdated Show resolved Hide resolved
tests/nlu/test_evaluation.py Outdated Show resolved Hide resolved
tests/nlu/test_evaluation.py Show resolved Hide resolved
tests/nlu/test_evaluation.py Show resolved Hide resolved
@alwx alwx force-pushed the train-model-tests branch from 063b98f to 0fb4b8b Compare March 23, 2021 08:17
@alwx alwx requested a review from wochinge March 23, 2021 08:47
wochinge
wochinge reviewed Mar 23, 2021
View reviewed changes
tests/core/test_training.py Outdated Show resolved Hide resolved
tests/nlu/classifiers/test_diet_classifier.py Outdated Show resolved Hide resolved
tests/nlu/classifiers/test_diet_classifier.py Outdated Show resolved Hide resolved
tests/nlu/test_evaluation.py Outdated Show resolved Hide resolved
@alwx alwx requested a review from wochinge March 23, 2021 15:38
wochinge
wochinge approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@alwx alwx enabled auto-merge March 25, 2021 20:42
@alwx alwx merged commit d6ee251 into main Mar 25, 2021
@alwx alwx deleted the train-model-tests branch March 25, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve tests which train model
2 participants
@alwx @wochinge