validate model config #7965
Merged
validate model config #7965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wochinge
commented
Feb 16, 2021
wochinge
commented
Feb 16, 2021
| filename: The path to the file which should be read. | ||
|
|
||
| Raises: | ||
| YamlValidationException: In case the model configuration doesn't match the |
There was a problem hiding this comment.
that's a different one than before but in my opinion the correct one. Double checked the code and nothing depends on the exact exception type.
wochinge
force-pushed
the
config-file-schema-validation
branch
from
8c85976 to
3bca31f
Compare
alwx
approved these changes
Feb 18, 2021
| content = read_file(filename) | ||
|
|
||
| rasa.shared.utils.validation.validate_yaml_schema(content, schema) | ||
| return read_yaml(content) |
There was a problem hiding this comment.
I changed how it works in my PR (#7968) but it should still be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
endpoints.yml,credentials.yml) using a schema instead of a Python checkrasa.sharedcode but aren't inrasa.sharedtorasa.sharedlanguagenot a required key after double checking with TyStatus (please check what you already did):
black(please check Readme for instructions)