Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not break if update.message is None #7687

Closed
wants to merge 1 commit into from

Conversation

tranchitella
Copy link

@tranchitella tranchitella commented Jan 6, 2021

If the update doesn't contain a message, which is true for edited
messages, return a successful response instead of raising an exception
and returning an error to Telegram.

Signed-off-by: Fabio Tranchitella [email protected]

Issue: #7686

If the update doesn't contain a message, which is true for edited
messages, return a successful response instead of raising an exception
and returning an error to Telegram.

Signed-off-by: Fabio Tranchitella <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Jan 6, 2021

CLA assistant check
All committers have signed the CLA.

@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @tmbo will take a look at it as soon as possible ✨

@sara-tagger sara-tagger requested a review from tmbo January 7, 2021 07:00
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 thanks a lot for that telegram fix. The code lgtm. Do you mind adding a test to avoid a regression in the future?

Base automatically changed from master to main January 22, 2021 11:15
@tranchitella
Copy link
Author

Superseded by #8719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants