Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration guide for policies #7522

Merged
merged 3 commits into from
Dec 11, 2020

Conversation

joejuzl
Copy link
Contributor

@joejuzl joejuzl commented Dec 11, 2020

Proposed changes:
Add migration steps for rasa 2.1 to 2.2 caused by continuous training

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀


### Policies

[Policies](./policies.mdx) now require a `**kwargs` argument in their constructor and `load` method.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also have a changelog for this, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I don't think so. Will we have one changelog for the whole of continuous training?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also add a changelog mentioning this change and then e.g. point to the migration guide.

Will we have one changelog for the whole of continuous training?

I think this change is somewhat unrelated to the training (we needed it, but we could have also done the policy interface change on its own) so I think it deserves it's own changelog. Especially because it's a deprecation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I can add it in this PR then. What issue number should we use?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mhm, either the number of this PR or probably better the one from the PR which introduced the change.

@joejuzl joejuzl requested a review from wochinge December 11, 2020 13:40
@joejuzl joejuzl merged commit 903d25a into continuous_training Dec 11, 2020
@joejuzl joejuzl deleted the continious_training_migration_guide branch December 11, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants