7330 Add functionality to check if a model is fine-tunable #7427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joejuzl
force-pushed
the
7330/check_if_model_is_fine-tunable
branch
from
b365fb3 to
60e0ac1
Compare
joejuzl
commented
Dec 1, 2020
dakshvar22
requested changes
Dec 1, 2020
wochinge
reviewed
Dec 3, 2020
tests/core/test_model.py
Outdated
| (_fingerprint(stories=["other"]), False), | ||
| ], | ||
| ) | ||
| def test_fine_tune_fingerprint_changed(fingerprint2, changed): |
tests/core/test_model.py
Outdated
| [("2.1.0", "2.1.0", True), ("2.0.0", "2.1.0", True), ("2.1.0", "2.0.0", False),], | ||
| ) | ||
| async def test_can_fine_tune_min_version( | ||
| project: Text, monkeypatch, old_model_version, min_compatible_version, can_tune |
tests/core/test_model.py
Outdated
| if "epochs" in p: | ||
| p["epochs"] += 10 | ||
|
|
||
| importer.get_config = asyncio.coroutine(lambda: config) |
There was a problem hiding this comment.
asyncio.coroutine is deprecated 😬
|
@dakshvar22 is the |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Adds a new method
rasa.model.can_fine_tunewhich uses fingerprinting to determine if a model can be fine-tuned.Status (please check what you already did):
black(please check Readme for instructions)