-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make converter support response key for test stories #7080
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job testing that! 👍
One question - can we name these tests the same way? They are almost the same, the only difference is that one test normal stories, and the other - test stories.
Also - could you please add a changelog entry?
assert content == ( | ||
f'version: "{LATEST_TRAINING_DATA_FORMAT_VERSION}"\n' | ||
"stories:\n" | ||
"- story: id\n" | ||
" steps:\n" | ||
" - intent: out_of_scope/other\n" | ||
" user: |-\n" | ||
" hahaha\n" | ||
" - action: utter_out_of_scope/other\n" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OPT: style suggestion, use multiline string instead (needs import textwrap
)
assert content == ( | |
f'version: "{LATEST_TRAINING_DATA_FORMAT_VERSION}"\n' | |
"stories:\n" | |
"- story: id\n" | |
" steps:\n" | |
" - intent: out_of_scope/other\n" | |
" user: |-\n" | |
" hahaha\n" | |
" - action: utter_out_of_scope/other\n" | |
) | |
assert content == textwrap.dedent(f""" | |
version: "{LATEST_TRAINING_DATA_FORMAT_VERSION}" | |
stories: | |
- story: id | |
steps: | |
- intent: out_of_scope/other | |
user: |- | |
hahaha | |
- action: utter_out_of_scope/other | |
""") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!! since it already got merged, I will consider this for the next test I write!
Closes #7034
Proposed changes:
MarkdownStoryReader::_parse_message
useintent_response_key
if aresponse key
is usedStatus (please check what you already did):
black
(please check Readme for instructions)