Force retraining of outdated models #7073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a pull request 🚀 @b-quachtran will take a look at it as soon as possible ✨ |
|
@alwx 🙏 |
alwx
approved these changes
Dec 1, 2020
There was a problem hiding this comment.
Thank you for your contribution and sorry that it took me so much time to get it reviewed.
The code looks good. I was thinking that it might make sense to add a test for outdated models and checking if the model is actually detected as the outdated (it'd be easier to just move model_outdated to a separate function and add a small test for this function)
However, it's a relatively small thing, so I am going to approve this PR anyway.
wochinge
reviewed
Jun 7, 2021
| rasa_version: Text = "1.0", | ||
| ) -> Fingerprint: | ||
| rasa_version: Text = MINIMUM_COMPATIBLE_VERSION, | ||
| ): |
There was a problem hiding this comment.
can you please re-add the removed return type?
|
@pheel Please feel free to re-open if you have time to continue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this, Rasa is able to boot when detected model is outdated. Since this, Core-only trainings are able to fall back on using an interpreter from the zipped model. If the zipped NLU model is outdated, Rasa will not train.
Status (please check what you already did):
black(please check Readme for instructions)