Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return all sessions for GET /story #6979

Merged
merged 51 commits into from
Oct 16, 2020
Merged

Return all sessions for GET /story #6979

merged 51 commits into from
Oct 16, 2020

Conversation

ricwo
Copy link
Contributor

@ricwo ricwo commented Oct 9, 2020 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@ricwo ricwo requested a review from wochinge October 11, 2020 21:06
wochinge
wochinge reviewed Oct 13, 2020
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juicy PR in the middle of some technical debt 🚀
I made a lot of comments - most of them are discussion items.

changelog/6860.improvement.md Outdated Show resolved Hide resolved
changelog/6860.improvement.md Show resolved Hide resolved
rasa/core/processor.py Outdated Show resolved Hide resolved
rasa/core/processor.py Show resolved Hide resolved
rasa/core/processor.py Show resolved Hide resolved
rasa/shared/core/trackers.py Show resolved Hide resolved
rasa/server.py Show resolved Hide resolved
rasa/server.py Show resolved Hide resolved
rasa/server.py Show resolved Hide resolved
rasa/server.py Outdated Show resolved Hide resolved
@wochinge wochinge mentioned this pull request Oct 13, 2020
Merged
12 tasks
@ricwo ricwo requested a review from wochinge October 15, 2020 16:52
wochinge
wochinge approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think the new TrackerStore method makes it way cleaner 🥇

rasa/core/tracker_store.py Outdated Show resolved Hide resolved
rasa/core/tracker_store.py Show resolved Hide resolved
rasa/core/tracker_store.py Outdated Show resolved Hide resolved
rasa/core/tracker_store.py Outdated Show resolved Hide resolved
rasa/shared/core/events.py Outdated Show resolved Hide resolved
@rasabot rasabot merged commit de2f1ac into master Oct 16, 2020
@rasabot rasabot deleted the get-story branch October 16, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/story endpoint does not fetch full tracker
3 participants
@ricwo @wochinge @rasabot