Use NaturalLanguageInterpreter factory in agent internal method #6274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of creating class directly
|
Thanks for submitting a pull request 🚀 @erohmensing will take a look at it as soon as possible ✨ |
|
Hey @pheel, can you elaborate on how your change improves upon the existing code? it seems that the create method will end up instantiating a RasaNLUInterpreter in a few calls in any case. |
|
@erohmensing I agree this is a rather inconsequential change on its own... This was done in the context of making UnsupportedModelError non-fatal (5faa4bb). Maybe it makes more sense to move this commit over there? |
|
Makes sense to me! |
|
Gotcha. Moved to #6276. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)