-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moodbot with rules & yml files #6229
Conversation
@ArjaanBuijk thanks for submitting that :D The stories also need to be converted to the yaml format, and so does the nlu training data - could you do that as well? not sure if any other changes are needed e.g. in the domain file, but it's good to take a look at the |
|
||
- story: sad path 1 | ||
steps: | ||
- intent: mood_unhappy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i actually wonder if this is the correct split here 🤔 because "mood_unhappy" is the direct response to the bots greeting (it says "hi how are you" or something)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akelad ,
I restored the greet->utter_greet as starting point of all the stories, and removed the corresponding rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me now! It seems like a bunch of tests are failing though (I guess they rely on moodbot). Do you have time to take a look at fixing them?
@ArjaanBuijk do you have time to fix the tests? |
I based my PR in #6323 on this and I think I fixed the tests (we'll see if CI passes, fingers crossed). so might make sense to close this one and just merge the other one. |
sounds fine to me |
Proposed changes: