Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'convert_predictions_into_entities' #6191

Merged
merged 10 commits into from
Jul 15, 2020
Merged

Update 'convert_predictions_into_entities' #6191

merged 10 commits into from
Jul 15, 2020

Conversation

tabergma
Copy link
Contributor

@tabergma tabergma commented Jul 13, 2020

Proposed changes:
If two entities are separated by a comma, they are currently detected as one entity. Example:
please add buffalo, ranch, mustard, barbeque sauces results in {'entity': 'sauces', 'start': 11, 'end': 43, 'value': 'buffalo, ranch, mustard, barbeque', 'extractor': 'DIETClassifier'}

This PR fixes this. Entities separated by a comma will be listed as individual entities.

Related to forum post

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@tabergma tabergma requested a review from ricwo July 13, 2020 08:21
rasa/nlu/extractors/extractor.py Outdated Show resolved Hide resolved
rasa/nlu/extractors/extractor.py Outdated Show resolved Hide resolved
rasa/nlu/extractors/extractor.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ricwo ricwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding those comments 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants