Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix for triggering custom utter message, when message contains no value or integer value #5875

Merged
merged 9 commits into from
Jul 6, 2020
Merged

Bug fix for triggering custom utter message, when message contains no value or integer value #5875

merged 9 commits into from
Jul 6, 2020

Conversation

Archish27
Copy link
Contributor

@Archish27 Archish27 commented May 22, 2020 •
edited by erohmensing
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Archish27 Archish27 changed the title Bug fix 5453 Bug fix for triggering custom utter message, when message contains no value or integer value May 22, 2020
@Archish27 Archish27 mentioned this pull request May 22, 2020
Closed
@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @rgstephens will take a look at it as soon as possible ✨

@sara-tagger sara-tagger requested a review from rgstephens May 25, 2020 06:41
rgstephens
rgstephens approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@rgstephens rgstephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission, looks good.

@Archish27
Copy link
Contributor Author

@rgstephens / @erohmensing Can someone merge this?

@erohmensing erohmensing merged commit dcb0f2d into RasaHQ:master Jul 6, 2020
@erohmensing erohmensing mentioned this pull request Jul 28, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgstephens rgstephens rgstephens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

if custom utter message contains no value or integer value then rasa fails returning custom utter message
5 participants
@Archish27 @sara-tagger @rgstephens @erohmensing @rasabot