-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize testing output: Response Selection #5824
Conversation
@@ -604,7 +604,7 @@ def plot_story_evaluation( | |||
from sklearn.metrics import confusion_matrix | |||
from sklearn.utils.multiclass import unique_labels | |||
import matplotlib.pyplot as plt | |||
from rasa.nlu.test import plot_confusion_matrix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit unlikely that it happens but it could break someone's code relying on this function in some glue code of their own. Should we add a deprecation warning or keep a dummy function in rasa.nlu.test
which just calls the one in rasa.utils.plotting
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if that is needed as it will be released with 2.0. I also removed two cli options for naming the histogram and confusion matrix file which are not useful anymore. If you think it is needed, I'll keep those and add a deprecation warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmbo Just wanted to double check if this is fine.
@tabergma I pushed a small fix to add the
instead of
Otherwise all intents would just be |
@tabergma In the confusion matrix should we use the |
@dakshvar22 Good idea. Will try it now. |
Ahh, that would need a bigger refactor. Because getting the |
😄 Ok. As an alternative, we could also maybe use a legend that maps the actual response to |
I would say let us directly replace them with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small key change for avoiding the ambiguity. Looks great! 💯
Co-authored-by: Daksh Varshneya <[email protected]>
Co-authored-by: Daksh Varshneya <[email protected]>
* create plotting utils * write errors and successes for responses * fix file names * update plot filenames * add changelog entry * add missing docstrings * update tests * fix type * address deepsource issues * use io_utils * fix call to write_text_file * added complete intent and response key to the 'intent' key * Update rasa/nlu/test.py Co-authored-by: Daksh Varshneya <[email protected]> * Update rasa/nlu/test.py Co-authored-by: Daksh Varshneya <[email protected]> * use intent_target key for confustion matrix Co-authored-by: Daksh <[email protected]> Co-authored-by: Roberto <[email protected]>
Proposed changes:
related to #5748
Status (please check what you already did):
black
(please check Readme for instructions)